-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add data acceptance tests #1551
base: main
Are you sure you want to change the base?
Conversation
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
Thanks for the pull request! DAT should not be added directly to the tree, since they should be changing relatively frequently as the protocol evolves. Here's a build.rs from another repository which I think you could incorporate into your pull request to dynamically fetch the latest dat release |
Thanks @rtyler, I will fix it up prior to requesting review! I just left it there because I hadn't done the setup part yet and wanted to make it easy for others to take a look at. Should the build.rs drop the files on exit? or is the intention to leave them in the tree, but just add the data in an automated way? |
add dat testing cleaning up continuing cleanup assertions on table version being accessed add setup script for dat file download
25e9418
to
0c16a1a
Compare
I don't believe there is a need to drop the dat tests in an automated way, I think it's best to avoid re-downloading the test release unless necessary. |
@rtyler
-This one is unexpected.-
This one is expected. What is the simplest way to coerce types? Tasks:
|
Let me look through this one |
Description
Adds data acceptance tests
Related Issue(s)
Documentation
delta-incubator/dat