Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Robert Pack <[email protected]>
  • Loading branch information
dispanser and roeap authored Nov 7, 2023
1 parent 5583247 commit a24f2eb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion crates/deltalake-core/src/logstore/default_logstore.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl DefaultLogStore {
/// * `storage` - A shared reference to an [`object_store::ObjectStore`] with "/" pointing at delta table root (i.e. where `_delta_log` is located).
/// * `location` - A url corresponding to the storage location of `storage`.
pub fn new(storage: ObjectStoreRef, config: LogStoreConfig) -> Self {
DefaultLogStore { storage, config }
Self { storage, config }
}

/// Create log store
Expand Down
2 changes: 1 addition & 1 deletion crates/deltalake-core/src/logstore/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ pub trait LogStore: Sync + Send {
// TODO: maybe a bit of a hack, required to `#[derive(Debug)]` for the operation builders
impl std::fmt::Debug for dyn LogStore + '_ {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
self.object_store().fmt(f)
write!(f, "LogStore({})", self.root_url())
}
}

Expand Down

0 comments on commit a24f2eb

Please sign in to comment.