Skip to content

Commit

Permalink
chore: remove uv.lock which should not be checked in
Browse files Browse the repository at this point in the history
From the [documentation](https://docs.astral.sh/uv/concepts/projects/layout/#the-lockfile)

> Unlike the pyproject.toml, which is used to specify the broad requirements of your project, the lockfile contains the exact resolved versions that are installed in the project environment. This file should be checked into version control, allowing for consistent and reproducible installations across machines.
>
> A lockfile ensures that developers working on the project are using a consistent set of package versions. Additionally, it ensures when deploying the project as an application that the exact set of used package versions is known.

The problem with the presence of this `uv.lock` for purposes of development of a library like `deltalake` is that `pip` installations of the released package will _not_ have the contents of that `uv.lock` file.

Therefore I want it to be removed so that our local installations, and CI, are always using `pyproject.toml` to resolve their dependencies in a manner which is consistent with the users of the installed package.

Signed-off-by: R. Tyler Croy <[email protected]>
  • Loading branch information
rtyler committed Dec 17, 2024
1 parent 1c115a8 commit 951f814
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 1,165 deletions.
3 changes: 0 additions & 3 deletions .github/actions/setup-env/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ runs:

- name: Install uv
uses: astral-sh/setup-uv@v3
with:
enable-cache: true
cache-dependency-glob: "python/uv.lock"

- name: Set up Python ${{ inputs.python-version }}
uses: actions/setup-python@v4
Expand Down
1 change: 1 addition & 0 deletions python/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ docs/build
dat-data

wheels/
uv.lock
3 changes: 2 additions & 1 deletion python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ build-backend = "maturin"

[project]
name = "deltalake"
version = "0.22.4"
description = "Native Delta Lake Python binding based on delta-rs with Pandas integration"
readme = "README.md"
license = { file = "licenses/deltalake_license.txt" }
Expand Down Expand Up @@ -97,4 +98,4 @@ markers = [

[tool.coverage.run]
branch = true
source = ["deltalake"]
source = ["deltalake"]
Loading

0 comments on commit 951f814

Please sign in to comment.