[WIP] Stats all #1627
Draft
[WIP] Stats all #1627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
DrakeLin
force-pushed
the
drake-lin_data/stats-all
branch
from
73fa938 to
e3b6498
Compare
Fokko
reviewed
Jan 19, 2026
| }) | ||
| .collect(); | ||
| let data = StructArray::try_new(output_fields.into(), output_cols, None)?; | ||
| let data = StructArray::try_new(output_fields.into(), output_cols, source_null_buffer)?; |
Collaborator
There was a problem hiding this comment.
Great catch! Should we split this out into a separate PR? This is a pretty serious bug
Collaborator
|
I'm still learning, but I would also expect that we extend the |
Fokko
reviewed
Jan 19, 2026
|
|
||
| StructTypeBuilder::from_schema(mandatory_add_file_schema()) | ||
| .add_field(StructField::nullable( | ||
| "stats", |
Collaborator
There was a problem hiding this comment.
Should we re-use this name? I think this might cause confusion since it will also contain the blob
Fokko
reviewed
Jan 19, 2026
| stats_schema: Option<&StructType>, | ||
| ) -> DeltaResult<( | ||
| impl Iterator<Item = DeltaResult<ActionsBatch>> + Send, | ||
| Option<bool>, |
Collaborator
There was a problem hiding this comment.
Why do we need to wrap the bool in an option?
Fokko
reviewed
Jan 19, 2026
| checkpoint_read_schema: SchemaRef, | ||
| meta_predicate: Option<PredicateRef>, | ||
| ) -> DeltaResult<impl Iterator<Item = DeltaResult<ActionsBatch>> + Send> { | ||
| stats_schema: Option<&StructType>, |
Collaborator
There was a problem hiding this comment.
Should this be a SchemaRef as well? In the case of wide tables, it can be pretty big (a multiple of the columns in the table itself). And should we add it the docstring?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
How was this change tested?