-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idrac_os_deployment): added support for ubuntu installation #784
base: collections
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
update: yes | ||
apt: | ||
preserve_sources_list: false | ||
mirror-selection: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have to set this at all? maybe just remove this section and see if it works... ?
@@ -423,7 +423,7 @@ Role Variables | |||
</tr> | |||
<tr> | |||
<td>idrac_os_deployment_supported_os</td> | |||
<td>{ RHEL: ["8", "9"], ESXI: ["8"] }</td> | |||
<td>{ RHEL: ["8", "9"], ESXI: ["8"], UBUNTU: ["jammy"] }</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder naming 22.04
vs jammy
- what is better
https://wiki.ubuntu.com/Releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since in the versioning format, he has not considered patch, both seems to be ok. Still if we have chanceof having different kickstsrt template based on versions, i would recommend to go with 22.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all the Ubuntu jammy versions, the kickstarter(auto-install) template is the same
39be8ab
to
8a8e291
Compare
Have updated the code according to the comments and pushed them! |
9e34904
to
1a9484d
Compare
Signed-off-by: sakethanne <[email protected]>
1a9484d
to
02e8d5a
Compare
Have updated the code according to the comments and pushed them! |
Description
This pull request extends the functionality of the idrac_os_deployment Ansible role to provide native support for Ubuntu Jammy (Ubuntu 22.04 LTS). This includes updates to the OS detection logic, modifications to ensure compatibility with the iDRAC OS deployment process, and test validation for seamless integration.
The enhancements address the gap in supporting newer Ubuntu versions, aligning the role with modern deployment requirements.
GitHub Issues
List the GitHub issues impacted by this PR: #780
Currently only RHEL and EXSI have native support for the idrac_os_deployment role and it currently does not have native support for the Ubuntu OS. | #780
ISSUE TYPE
COMPONENT NAME
Role: idrac_os_deployment
OUTPUT
ADDITIONAL INFORMATION
The changes resolve the inability of the idrac_os_deployment role to recognize and process Ubuntu Jammy 22.04.
Key Updates:
Enhanced the OS detection mechanism to include Ubuntu Jammy 22.04.
Adjusted playbook logic to handle the differences in OS setup for Jammy compared to older Ubuntu versions.
Updated documentation to include instructions for deploying Ubuntu 22.04.
Checklist: