Support installing Whetstone in modules using the new Android KMP plugin#114
Open
kingsleyadio wants to merge 2 commits intodeliveryhero:mainfrom
Open
Support installing Whetstone in modules using the new Android KMP plugin#114kingsleyadio wants to merge 2 commits intodeliveryhero:mainfrom
kingsleyadio wants to merge 2 commits intodeliveryhero:mainfrom
Conversation
kingsleyadio
force-pushed
the
kingsley/support-new-android-kmp
branch
4 times, most recently
from
8002788 to
efea696
Compare
sepbehroozi
approved these changes
Jul 1, 2025
sepbehroozi
left a comment
sepbehroozi
left a comment
There was a problem hiding this comment.
Please don't consider my review as a legit approval :D It's not my area of expertise. I was just excited to see the contribution ❤️ Kudos to Mr. Kingsley
Collaborator
|
Could you rebase to current state, lets merge this. |
kingsleyadio
force-pushed
the
kingsley/support-new-android-kmp
branch
from
efea696 to
da84f6a
Compare
kingsleyadio
force-pushed
the
kingsley/support-new-android-kmp
branch
from
da84f6a to
c7e8dd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support android library modules that use the new KMP plugin