Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to use user_id in recovery and settings controller #929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

No need to use user_id in recovery and settings controller #929

wants to merge 1 commit into from

Conversation

adantart
Copy link

Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Fixed issues #926

@thyseus
Copy link
Contributor

thyseus commented May 23, 2017

Good one. Could you re-open your PR here: https://github.com/dabilite/yii2-user/pulls ? Currently we have a fork of dektrium/yii2-user.

@thiagotalma
Copy link
Member

Help is needed to review this.

@SamMousa @philippfrenzel @thyseus @bscheshirwork @tsdogs

@bscheshirwork
Copy link
Contributor

  • no need user_id. So clearly.
  • additional request to db
  • BC can be broken (url manager rule will be changed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: to be verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adantart @thyseus @thiagotalma @bscheshirwork