"new static" to "Yii::createObject" fix

[bscheshirwork]

Result of finder (activeQuery createModels) is correct configure new model

Example usage (without fix not included/trigger on beforeDelete):

    'modules' => [
        'user' => [
            'class' => 'dektrium\user\Module',
            'enableRegistration' => false,
            'adminPermission' => 'administrateUser',
            'modelMap' => [
                'User' => [
                    'class' => 'dektrium\user\models\User',
                    'on ' . ActiveRecord::EVENT_AFTER_INSERT => function ($event) {
                        $id = $event->sender->getId();
                        $roleName = 'user';
                        $auth = Yii::$app->authManager;
                        if (!array_key_exists($roleName, $auth->getRolesByUser($id))) {
                            $userRole = $auth->getRole($roleName);
                            $auth->assign($userRole, $id);
                        }
                    },
                    'on ' . ActiveRecord::EVENT_BEFORE_DELETE => function ($event) {
                        $id = $event->sender->getId();
                        $auth = Yii::$app->authManager;
                        return $auth->revokeAll($id);
                    },
                ],
            ],
        ],
    ],

Q	A
Is bugfix?	yes

[thiagotalma]

Help is needed to review this.

@SamMousa @philippfrenzel @thyseus @bscheshirwork @tsdogs

[SamMousa]

I disagree with this change. I'd rather not add a dependency on the DI container to AR. The framework doesn't do it either so we'd be deviating from "normal" AR.

Instead I'd recommend you implement a behavior instead.

[bscheshirwork]

I will set config of User class into modelMap. I expect "create new object with config". Right?

[SamMousa]

@bscheshirwork not for AR models in most cases..
https://github.com/yiisoft/yii2/blob/master/framework/db/BaseActiveRecord.php#L1180

[bscheshirwork]

@SamMousa
https://github.com/yiisoft/yii2/blob/72b69e359a3d35bfb5fab55b7ca20e56a9e51cf1/framework/db/BaseActiveRecord.php#L1165-L1181

tell we about redefine it if needed

[bscheshirwork]

... And so many times in framework code using DI in same case. Case "set class throw config"

[SamMousa]

I don't get what you mean

[bscheshirwork]

modelMap property is a config to set you own classes

[SamMousa]

I know that; but I don't get the arguments. Anyway go ahead; I don't use the module anymore so if you feel it's a good addition I don't mind it :)

[bscheshirwork]

If we use

new static();

we lose any config settings
and use standard AR class
in data population after find.

I don't use the module anymore

p.s.: @SamMousa
what solution you use?

[SamMousa]

p.s.: @SamMousa
what solution you use?

I use my own solution (meaning it's different for every project)