-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #453 : Keep strings in cache instead of jquery objects #465
base: master
Are you sure you want to change the base?
Conversation
This might slow down navigation due to the extra overhead of HTML serialization and parsing, and might have other adverse side-effects as well. If you want to make a significant change like this happen in a library, you should try making a stronger case than just a pull request with no description. Like, you might explore:
|
Hello Sorry, didn't add description here since discussion is in the issue... About memory, don't have time to make a bench, but it's obvious, nodes will take more memory than simple strings. About perfs : http://jsperf.com/jquery-clone-vs-html-construction And about video bug, I tried a lot of things, it is the better and simplest way I found to solve it. One caveat in using html() :
|
Yeah that's what I'm worried about. We can explore this direction, and I can definitely believe that HTML strings can make up less memory than storing nodes, but we'll need to perform some testing on real-world-looking pages with dozens or even hundreds of navigations between reloads and analyze how it affects performance stats. |
I'll try to build a bench in the week. |
Little bench with more tags : http://jsperf.com/clone-vs-html-bench |
On Mon, Dec 8, 2014 at 8:29 AM, Kevin LEVRON [email protected]
|
No description provided.