[WIP] Merging AutoSP into DeepSpeed#7860
Draft
neeldani wants to merge 3 commits intodeepspeedai:masterfrom
Draft
[WIP] Merging AutoSP into DeepSpeed#7860neeldani wants to merge 3 commits intodeepspeedai:masterfrom
neeldani wants to merge 3 commits intodeepspeedai:masterfrom
Conversation
27 tasks
Collaborator
|
Hi @neeldani, Since this is a large PR, let’s proceed step by step. Here are my suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP PR to merge AutoSP into DeepSpeed. AutoSP enables Ulysses styled sequence parallelism at the compiler level for transformer based torch models.
AutoSP's passes operate at the Torch IR level before partitioning of the forward/ backward graph and are mainly responsible for:
(1) auto-sharding of the input sequence, position ids and labels
(2) inserting the a2a before and after attention for Ulysses-styled sequence parallelism
Pending items/ discussion:
For reviewers
The compiler passes would remain the same however the interface from DeepSpeed config will be updated and so the initial review can be limited to the design of the passes.
Here is where the backend for AutoSP is initialized and passes are triggered
The directory
bench_dc_ulyssescontains the benchmarking scripts and will not be merged. Butrun_acc_lm.pycontains an example of users could use AutoSP.