Reject non-finite fp16 loss_scale across config and ZeRO paths#7856
Draft
harshang03 wants to merge 1 commit intodeepspeedai:masterfrom
Draft
Reject non-finite fp16 loss_scale across config and ZeRO paths#7856harshang03 wants to merge 1 commit intodeepspeedai:masterfrom
harshang03 wants to merge 1 commit intodeepspeedai:masterfrom
Conversation
Reject non-finite or non-positive loss-scale values during fp16 config parsing, loss-scaler construction, and ZeRO override/setter flows to prevent inf-driven initialization that later produces NaN gradients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
loss_scale,loss_scale_window,hysteresis, andmin_loss_scaleso invalid values fail during config parsing.LossScaleConfigandCreateLossScalerto reject invalid static/dynamic loss-scale arguments even if values are injected outside config parsing.Screenshot or video (only for visual changes)
GitHub Issue Link (if applicable)
Testing Plan
python -m pytest tests/unit/runtime/test_ds_config_model.py tests/unit/runtime/half_precision/test_loss_scale_validation.pyContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.