Skip to content

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Aug 7, 2025

This is ready for a first review.

What's missing:

  • one or two videos of the Agent in action
  • the deployment example in Haystack demos.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@anakin87 anakin87 marked this pull request as ready for review August 7, 2025 16:43
@anakin87 anakin87 requested a review from a team as a code owner August 7, 2025 16:43
@anakin87 anakin87 requested a review from bilgeyucel August 7, 2025 16:43
Copy link

review-notebook-app bot commented Aug 8, 2025

View / edit / reply to this conversation on ReviewNB

bilgeyucel commented on 2025-08-08T07:00:32Z
----------------------------------------------------------------

First, we'll install all the necessary dependencies:

  • Haystack integrations: MCP and Google GenAI (you can use the integration pages here instead)
  • Playwright dependencies: these are needed to successfully run it on Colab (typo in successfully)


anakin87 commented on 2025-08-13T10:16:55Z
----------------------------------------------------------------

Fixing the typo.

Keeping links to docs, which are more completed and up to date (especially for MCP).

Copy link

review-notebook-app bot commented Aug 8, 2025

View / edit / reply to this conversation on ReviewNB

bilgeyucel commented on 2025-08-08T07:00:33Z
----------------------------------------------------------------

We need to remove the TODO line here


Copy link

review-notebook-app bot commented Aug 8, 2025

View / edit / reply to this conversation on ReviewNB

bilgeyucel commented on 2025-08-08T07:00:33Z
----------------------------------------------------------------

We add the "browser_snapshot" tool but it doesn't use it for this query, right?


anakin87 commented on 2025-08-13T10:16:17Z
----------------------------------------------------------------

In some runs, the Agent uses it to better understand

Copy link

review-notebook-app bot commented Aug 8, 2025

View / edit / reply to this conversation on ReviewNB

bilgeyucel commented on 2025-08-08T07:00:34Z
----------------------------------------------------------------

Maybe link to the tutorial here


Copy link

review-notebook-app bot commented Aug 8, 2025

View / edit / reply to this conversation on ReviewNB

bilgeyucel commented on 2025-08-08T07:00:35Z
----------------------------------------------------------------

TODO line


Copy link

review-notebook-app bot commented Aug 8, 2025

View / edit / reply to this conversation on ReviewNB

bilgeyucel commented on 2025-08-08T07:00:36Z
----------------------------------------------------------------

Another todo reminder


Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest:

  • add videos
  • Remove the text linking to demos until we have it on haystack-demos
  • Merge the PR :)

Copy link
Member Author

In some runs, the Agent uses it to better understand


View entire conversation on ReviewNB

Copy link
Member Author

Fixing the typo.

Keeping links to docs, which are more completed and up to date (especially for MCP).


View entire conversation on ReviewNB

@anakin87 anakin87 merged commit 4df06eb into main Aug 13, 2025
1 check passed
@anakin87 anakin87 deleted the browser-agent branch August 13, 2025 10:54
@anakin87 anakin87 self-assigned this Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants