Skip to content

Conversation

Amnah199
Copy link
Contributor

No description provided.

@Amnah199 Amnah199 requested a review from a team as a code owner July 17, 2025 16:22
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Amnah199 Amnah199 requested a review from davidsbatista July 18, 2025 12:00
@davidsbatista
Copy link
Contributor

sorry, one last comment, I think you need to remove the ## Installation from the cell, the %%bash needs to be the only thing at the header - you can merge after

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small comment, merge it after

Copy link
Contributor

@bilgeyucel bilgeyucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Amnah199! I left my comments

Co-authored-by: Bilge Yücel <[email protected]>
@Amnah199 Amnah199 merged commit f974980 into main Jul 21, 2025
1 check passed
@Amnah199 Amnah199 deleted the add-llama-stack-cookbook branch July 21, 2025 09:46
@@ -0,0 +1,225 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to the agent documentation page here?


Reply via ReviewNB

@@ -0,0 +1,225 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to the Tool documentation page


Reply via ReviewNB

@@ -0,0 +1,225 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add more info here to explain the relation between two:

"Now, let's create a LlamaStackChatGenerator and pass it to the Agent. The Agent component will use the model running with LlamaStackChatGenerator to reason and make decisions."


Reply via ReviewNB

@@ -0,0 +1,225 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Now, when we ask questions, the Agent will utilize both the provided tool and the LlamaStackChatGenerator to generate answers. We enable the streaming in Agent through streaming_callback, so you can observe the tool calls and results in real time."


Reply via ReviewNB

@@ -0,0 +1,225 @@
{
Copy link
Contributor

@bilgeyucel bilgeyucel Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markdown here needs to get fixed:

"[Llama Stack docs](https://llama-stack.readthedocs.io/en/latest/providers/inference/index.html)."


Reply via ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants