Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added optimizer n evolutions #126

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Conversation

Darinochka
Copy link
Collaborator

No description provided.

Comment on lines 70 to 72
results = ctx.optimization_info.dump_evaluation_results()
decision_metric = results["metrics"]["decision"]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сделать опцию выбирать на каком сплите считать метрику (потому что подгоняться под тест плохо)

Comment on lines 63 to 65
dataset = load_dataset(input_path)
generator = UtteranceEvolver(Generator(), evolutions, seed)
generator.augment(dataset, split_name=split, n_evolutions=n)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

вычислительно не эффективно, лучше на каждой итерации по одной эволюции добавлять

@voorhs voorhs self-requested a review February 12, 2025 11:44
Comment on lines 59 to 62
def _choose_search_space(search_space: str | None) -> list[dict[str, Any]] | Path | str:
if search_space is None:
return SEARCH_SPACE
return search_space
Copy link
Collaborator

@voorhs voorhs Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для случая когда на входе строка тут кажется пропущена конвертация в список словариков

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в Pipeline.from_search_space(search_space) можно подавать search_space как файл\строку

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

надо сконвертить весь этот функционал в класс наподобие UtteranceEvolver, только назвать его IncrementalUtteranceEvolver, чтобы у него был метод augment(dataset) наподобие того который у UtteranceEvolver

потому что текущая версия ограничена в использовании - только через CLI - а хотелось бы главным образом иметь питоновский апи

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants