Skip to content

Conversation

yunjianshijie
Copy link

@yunjianshijie yunjianshijie commented Aug 22, 2025

hulk inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9244H


Reserve space for ttm_resource_manager_func, ttm_resource_manager, ttm_bus_placement and ttm_resource in ttm_resource.h

Summary by Sourcery

Add DEEPIN_KABI_RESERVE entries to ttm_resource.h to maintain Deepin kernel ABI compatibility for TTM resource management structs

Bug Fixes:

  • Reserve space in struct ttm_resource_manager_func for future ABI changes
  • Reserve space in struct ttm_resource_manager for future ABI changes
  • Reserve space in struct ttm_bus_placement for future ABI changes
  • Reserve space in struct ttm_resource for future ABI changes

Copy link

sourcery-ai bot commented Aug 22, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The patch updates ttm_resource.h by including the Deepin KABI header and inserting DEEPIN_KABI_RESERVE padding fields into key DRM TTM structures to preserve Deepin ABI compatibility.

Class diagram for updated DRM TTM structures with Deepin KABI reserves

classDiagram
    class ttm_resource_manager_func {
        +void (*debug)(ttm_resource_manager*, drm_printer*)
        +DEEPIN_KABI_RESERVE(1)
        +DEEPIN_KABI_RESERVE(2)
        +DEEPIN_KABI_RESERVE(3)
        +DEEPIN_KABI_RESERVE(4)
    }
    class ttm_resource_manager {
        +uint64_t usage
        +DEEPIN_KABI_RESERVE(1)
        +DEEPIN_KABI_RESERVE(2)
    }
    class ttm_bus_placement {
        +phys_addr_t offset
        +bool is_iomem
        +ttm_caching caching
        +DEEPIN_KABI_RESERVE(1)
        +DEEPIN_KABI_RESERVE(2)
    }
    class ttm_resource {
        +list_head lru
        +DEEPIN_KABI_RESERVE(1)
        +DEEPIN_KABI_RESERVE(2)
        +DEEPIN_KABI_RESERVE(3)
        +DEEPIN_KABI_RESERVE(4)
    }
Loading

File-Level Changes

Change Details Files
Include Deepin KABI support header
  • Add #include <linux/deepin_kabi.h> at the top of ttm_resource.h
include/drm/ttm/ttm_resource.h
Add DEEPIN_KABI_RESERVE fields for ABI padding
  • Insert four DEEPIN_KABI_RESERVE entries in struct ttm_resource_manager_func
  • Insert two DEEPIN_KABI_RESERVE entries in struct ttm_resource_manager
  • Insert two DEEPIN_KABI_RESERVE entries in struct ttm_bus_placement
  • Insert four DEEPIN_KABI_RESERVE entries in struct ttm_resource
include/drm/ttm/ttm_resource.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign avenger-285714 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

Hi @yunjianshijie. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hulk inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9244H

---------------------------

Reserve space for ttm_resource_manager_func, ttm_resource_manager,
ttm_bus_placement and ttm_resource in ttm_resource.h

Signed-off-by: Wang Wensheng <[email protected]>
Signed-off-by: yunjianshijie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants