Skip to content

Conversation

yunjianshijie
Copy link

@yunjianshijie yunjianshijie commented Aug 21, 2025

hulk inclusion
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I90MTG


Reserve space for arm64 and x86 thread_info structure

Summary by Sourcery

Reserve space for the thread_info structure on arm64 by inserting KABI padding macros and include the deepin_kabi header in both arm64 and x86 to enable future thread_info ABI reservations

New Features:

  • Add DEEPIN_KABI_RESERVE slots in the arm64 thread_info struct to reserve future ABI space
  • Include the deepin_kabi header in both arm64 and x86 thread_info definitions for KABI support

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign opsiff for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sourcery-ai bot commented Aug 21, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the thread_info definitions for arm64 and x86 by importing the deepin_kabi header and inserting KABI reservation macros (on arm64) to allocate reserved space for the thread_info structure, ensuring ABI stability.

Class diagram for updated thread_info structure (arm64)

classDiagram
    class thread_info {
        +unsigned long flags
        +unsigned long tp_value
        +struct task_struct *task
        +void *scs_sp
        +u32 cpu
        +DEEPIN_KABI_RESERVE(1)
        +DEEPIN_KABI_RESERVE(2)
    }
Loading

Class diagram for updated thread_info structure (x86)

classDiagram
    class thread_info {
        // Existing fields (not shown in diff)
        +// Reserved space via DEEPIN_KABI_RESERVE macros (imported header)
    }
Loading

File-Level Changes

Change Details Files
Import deepin_kabi header into thread_info definitions
  • Added #include <linux/deepin_kabi.h> to arm64 thread_info.h
  • Added #include <linux/deepin_kabi.h> to x86 thread_info.h
arch/arm64/include/asm/thread_info.h
arch/x86/include/asm/thread_info.h
Reserve extra KABI slots in arm64 thread_info
  • Inserted DEEPIN_KABI_RESERVE(1) in arm64 thread_info
  • Inserted DEEPIN_KABI_RESERVE(2) in arm64 thread_info
arch/arm64/include/asm/thread_info.h

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

Hi @yunjianshijie. Thanks for your PR.

I'm waiting for a deepin-community member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

hulk inclusion
category: feature
bugzilla: https://gitee.com/openeuler/kernel/issues/I90MTG

-------------------------------

Reserve space for arm64 and x86 thread_info structure

Signed-off-by: Jialin Zhang <[email protected]>
Signed-off-by: yunjianshijie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants