build: update linter #489
build: update linter #489
Conversation
| @@ -1,6 +1,6 @@ | |||
| module github.com/decred/vspd/client/v4 | |||
|
|
|||
| go 1.19 | |||
There was a problem hiding this comment.
Why is this bumped? Nothing requires it.
| @@ -1,6 +1,6 @@ | |||
| module github.com/decred/vspd | |||
|
|
|||
| go 1.20 | |||
There was a problem hiding this comment.
It doesn't seem very prudent to me to require a new version of Go for all consumers just to add a linter.
There was a problem hiding this comment.
Agree with @davecgh here, leave the go.mod files as they are and the linter will just output a warning rather than causing a build failure:
==> lint types
WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.19) of your project is lower than Go 1.22
We can live with the warning for now and I will add this as a note to #488
| - fatcontext | ||
| - goconst | ||
| - godot | ||
| - gofmt | ||
| - goimports | ||
| - gosimple | ||
| - govet | ||
| - grouper |
There was a problem hiding this comment.
The default config for grouper has all functionality disabled, which means just adding it to this list does nothing.
Besides that, I don't agree with the premise of this linter. Why should it be forced that only singles or groups of declarations can be used? In some cases a single makes sense (example), and in other cases its helpful to group related values together (example).
| @@ -32,6 +33,8 @@ linters: | |||
| - predeclared | |||
| - reassign | |||
| - revive | |||
| - rowserrcheck | |||
There was a problem hiding this comment.
This project doesn't use SQL so these two linters are unnecessary.
| @@ -1,6 +1,6 @@ | |||
| module github.com/decred/vspd | |||
|
|
|||
| go 1.20 | |||
There was a problem hiding this comment.
Agree with @davecgh here, leave the go.mod files as they are and the linter will just output a warning rather than causing a build failure:
==> lint types
WARN [linters_context] copyloopvar: this linter is disabled because the Go version (1.19) of your project is lower than Go 1.22
We can live with the warning for now and I will add this as a note to #488
No description provided.