[v2.0] vsp: export vsp client #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
approved these changes
May 24, 2024
There was a problem hiding this comment.
I don't think I was aware of dcrdex using the vspd version of autoclient beyond a development branch, did that work actually land in master? Or in a release? My apologies if so.
Exporting the client from dcrwallet is definitely the preferred approach so I am in favour of this PR.
|
It's all good. I should have been subscribed to vspd repo notifications. |
jrick
approved these changes
May 24, 2024
|
this will get tagged 4.1.0 since it adds new public api again |
|
@buck54321 just noticed this pr was against the release branch and not master. Mind reopening also for master? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what the best course of action is here. We had worked with @jholdstock here and here to get a vsp client that we could use for
PurchaseTicketsin dcrdex. That code was removed 3 months later, oddly enough with the statement "At this point there are no known consumers of the vspd version of autoclient". Regardless, we would like to have access to the vsp client. Is there a reason it needs to be an internal package?