-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mm: Add BotProblems to BotStatus #2808
base: master
Are you sure you want to change the base?
Conversation
16239b3
to
4bcdffe
Compare
client/mm/mm.go
Outdated
// DeterminePlacementsErr is true if there was an unidentified error when | ||
// attempting to determine the rates at which to place orders. | ||
DeterminePlacementsErr error `json:"determinePlacementsErr"` | ||
// PlaceBuyOrdersErr is true if there was an unidentified error while | ||
// placing buy orders. | ||
PlaceBuyOrdersErr error `json:"placeBuyOrdersErr"` | ||
// PlaceBuyOrdersErr is true if there was an unidentified error while | ||
// placing sell orders. | ||
PlaceSellOrdersErr error `json:"placeSellOrdersErr"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lash three are type error
but description says "is true"
client/mm/utils.go
Outdated
problems.AccountSuspended = false | ||
problems.NoOracleAvailable = false | ||
problems.EmptyMarket = false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing problems.CEXOrderbookUnsynced
Unsure if related to these changes but will see a lot of errors running on simnet with a bot:
The one below this may be fixed in #2843
Can be fixed later. |
50cdb70
to
3da7e10
Compare
This PR adds a BotProblems struct to BotStatus that reports issues that bots are facing. Some problems such as wallet sync and connectivity are checked preemptively while others are reported when errors arise during determining what orders to place and when actually placing them. The preemptive checks are especially important for the Arb bot which additionally confirms that the trading limits allow for an additional trade. Balance deficiencies are also reported in BotProblems.
3da7e10
to
c1f4fd4
Compare
This PR adds a
BotProblems
struct toBotStatus
that reports issues that bots are facing. Some problems such as wallet sync and connectivity are checked preemptively while others are reported when errors arise during determining what orders to place and when actually placing them. The preemptive checks are especially important for the Arb bot which additionally confirms that the trading limits allow for an additional trade. Balance deficiencies are also reported inBotProblems
.