Flesh out merkle root construction page #38
Conversation
There was a problem hiding this comment.
I've dropped some comments on this, but fair warning - this is outside my wheelhouse.
Requesting a once-over from @davecgh if you have some time please.
| TXIDs and intermediate hashes are always in internal byte order when they're | ||
| concatenated, and the resulting merkle root is also in internal byte | ||
| order when it's placed in the block header. | ||
| This page explains what merkle trees are, how Decred uses them and provides step-by-step instructions for constructing compliant Merkle trees. |
There was a problem hiding this comment.
I'd suggest an oxford comma here
There was a problem hiding this comment.
So I thought the oxford comma was against the rules now, and have been trying to phase it out of my writing. Just googled it and was happy to see it's still legal in most contexts. It's just a "stylistic" choice, where it improves readability. Woot! Oxford comma added.
|
|
||
| ### Merkle Trees in Decred | ||
|
|
||
| Merkle roots are used to create compact summaries of all transactions in a block. These merkle roots can then be queried to quickly and efficiently verify whether or not a a transaction is included in a block. |
|
|
||
|  | ||
|
|
||
| !!! warning "Warning" |
There was a problem hiding this comment.
I think this warning should really be moved above the diagram. It feels strange that the last element on the page is a warning box, ie. a high priority message. It should be more prominent imo
|
|
||
| Merkle roots are used to create compact summaries of all transactions in a block. These merkle roots can then be queried to quickly and efficiently verify whether or not a a transaction is included in a block. | ||
|
|
||
| The block header of each block contains the merkle roots of two merkle trees, the `MerkleRoot` tree and `StakeRoot` tree. The `MerkleRoot` tree contains hashes of all regular transaction IDs. The `StakeRoot` tree contains hashes of stake-based transaction IDs (ticket purchases, votes, revocations, etc.). |
There was a problem hiding this comment.
To avoid the repetition we could say eitherThe header of each block... or Each block header...
There was a problem hiding this comment.
Nice compression. Used
|
@jholdstock, comments addressed. Missed merkle tree capitalization was an epic find/replace fail. |
Pulled content and diagrams from DCP-0005 to flesh out merkle root construction page.
At the bottom of the page I've copied content from the corresponding page on the Bitcoin devdocs. Update for Decred and reuse?