blockchain: Optimize exported header access. #1273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimizes the
FetchHeader
function to make use of the fact that all block nodes are now in memory and therefore it is no longer necessary to consult the database for them.It also renames the function to
HeaderByHash
so it is consistent with other similar functions such asHeaderByHeight
,BlockByHash
, andBlockByHeight
and updates all callers in the repo accordingly.This speeds up fetching all of the headers in the chain by roughly 3x to 4x for a chain height of 246,000 headers. Longer chains will benefit more.
For example, here is some timing information before and after this commit plus the full block index in memory commit for 246,000 headers:
7200 RPM HDD:
Previous fetch time: ~15.76s
New fetch time: ~4.17s
SSD:
Previous fetch time: ~12.63s
New fetch time: ~4.17s
This is work towards #1145.