Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(kubevirt): fix virt-controller tests #688

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Jan 31, 2025

Description

Fix unit tests for virt-controller.

Use to run tests:
ginkgo -succinct /home/dmitrii/Base/Flant/kubevirt/pkg/virt-controller/...

Why do we need it, and what problem does it solve?

Our patches introduce significant changes to the kubevirt codebase, so it is strictly necessary to keep kubevirt unit tests up to date to minimize the likelihood of bugs.

What is the expected result?

The tests are passed.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Sorry, something went wrong.

Signed-off-by: Isteb4k <dmitry.rakitin@flant.com>
@Isteb4k Isteb4k added this to the v0.16.0 milestone Jan 31, 2025
@Isteb4k Isteb4k marked this pull request as ready for review January 31, 2025 16:10
@Isteb4k Isteb4k merged commit 8cb706b into main Feb 3, 2025
14 of 15 checks passed
@Isteb4k Isteb4k deleted the test/kubevirt/fix-virt-controller-tests branch February 3, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants