Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubevirt): improve unmount for hotplug container disks #683

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaroslavborbat
Copy link
Member

@yaroslavborbat yaroslavborbat commented Jan 31, 2025

Description

This PR enhances the unmounting process for hotplugged container disks by introducing improvements that ensure a more reliable and thorough cleanup.

Changes

  1. Added the removal of mount point files after unmounting to clean up leftover artifacts.
  2. Updated the unmounting logic to rely not only on our managed mount records (stored in files) but also on the actual state of mount points.
    • The implementation now actively checks the real mount points on the system to verify their state and ensures they are properly unmounted.

Why do we need it, and what problem does it solve?

These changes make the unmounting process more robust and help prevent stale mount points from causing issues.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: kubevirt
type: fix
summary: Improve unmounting process by cleaning up mount point files and verifying actual mount states

@yaroslavborbat yaroslavborbat added this to the v0.15.1 milestone Jan 31, 2025
@yaroslavborbat yaroslavborbat force-pushed the fix/kubevirt/hp-container-disk-unmount branch from 0b59a93 to 2ebaf0a Compare January 31, 2025 09:31
Signed-off-by: Yaroslav Borbat <[email protected]>
@yaroslavborbat yaroslavborbat force-pushed the fix/kubevirt/hp-container-disk-unmount branch from 2ebaf0a to 95c2dae Compare January 31, 2025 09:32
@yaroslavborbat yaroslavborbat marked this pull request as draft January 31, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant