fix(vm): Improve KVVM Builder. Add method SetMetadata #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl64
reviewed
Jan 27, 2025
fl64
previously approved these changes
Jan 27, 2025
fl64
reviewed
Jan 27, 2025
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
yaroslavborbat
force-pushed
the
fix/vm/setmetadata
branch
from
2a0d447 to
108a66e
Compare
Signed-off-by: Yaroslav Borbat <[email protected]>
fl64
previously approved these changes
Jan 27, 2025
Signed-off-by: Yaroslav Borbat <[email protected]>
hardcoretime
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the SetMetadata method to the KVVM Builder. Previously, we did not set metadata in the KVVM template during creation, as it was synchronized later using a dedicated handler. While this approach worked for syncing metadata, it caused an issue with the initial pod scheduling.
Without setting metadata upfront, some required labels were missing during the initial pod scheduling phase. These labels are critical for features like pod affinity and anti-affinity rules. As a result, the initial scheduling could make incorrect decisions, potentially leading to rule violations or suboptimal placement.
By introducing the SetMetadata method, this PR ensures that metadata is properly set in the template during the initial build phase, preventing such scheduling issues.
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist