Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): fix false positive e2e CI runs #603

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

nevermarine
Copy link
Contributor

@nevermarine nevermarine commented Dec 23, 2024

Description

Add EXIT_CODE env for GitHub Actions to use as indicator of run's success

Why do we need it, and what problem does it solve?

Fix #593

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Add EXIT_CODE env for GitHub Actions to use as indicator of run's success

Signed-off-by: Maksim Fedotov <[email protected]>
@nevermarine nevermarine marked this pull request as ready for review December 23, 2024 11:24
@nevermarine nevermarine merged commit d7b875c into main Dec 23, 2024
13 of 14 checks passed
@nevermarine nevermarine deleted the fix/ci/fix-false-positive-e2e-ci-runs branch December 23, 2024 14:35
@universal-itengineer universal-itengineer modified the milestones: v0.14.2, v0.15.0 Dec 24, 2024
diafour pushed a commit that referenced this pull request Dec 25, 2024
Add EXIT_CODE env for GitHub Actions to use as indicator of run's success

Signed-off-by: Maksim Fedotov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants