refactor(vd): events #577
Merged
refactor(vd): events #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilrwx
force-pushed
the
refactor/vm/events
branch
3 times, most recently
from
f15a959 to
eb4bdab
Compare
danilrwx
force-pushed
the
refactor/vm/events
branch
2 times, most recently
from
37de4e8 to
6bb5d8b
Compare
danilrwx
force-pushed
the
refactor/vm/events
branch
2 times, most recently
from
c58e435 to
ae77516
Compare
Isteb4k
requested changes
Dec 23, 2024
images/virtualization-artifact/pkg/controller/vd/internal/attachee.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/source/object_ref_cvi.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/source/object_ref_vdsnapshot.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/source/registry.go
Show resolved
Hide resolved
Isteb4k
previously approved these changes
Dec 24, 2024
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Isteb4k
force-pushed
the
refactor/vm/events
branch
from
9597e8b to
3d46b05
Compare
Isteb4k
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding VirtualDisk events
Why do we need it, and what problem does it solve?
Adding events is aimed at improving problem finding and tracking the causes of state changes
What is the expected result?
New events on VirtualDisk resources
Checklist