fix(template): add missing fields to kube-rbac-proxy #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Fedotov <[email protected]>
diafour
approved these changes
Dec 13, 2024
nevermarine
deleted the
fix/template/add-missing-fields-to-kube-rbac-proxy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly set default fields in the customization patch for kube-rbac-proxy.
Why do we need it, and what problem does it solve?
Prevent infinite patching of cdi-apiserver and cdi-deployment by the cdi-operator. cdi-operator don't respect default values from Kubernetes API.
What is the expected result?
Checklist