fix(cdi): change clone strategy fot sds provisioners #573
+708
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
changed the title
Isteb4k
changed the base branch from
main
to
feat/cdi/improve-clone-performance
Isteb4k
force-pushed
the
feat/cdi/sds-clone-stragegy
branch
7 times, most recently
from
b029adc to
346a5e3
Compare
yaroslavborbat
previously approved these changes
Dec 16, 2024
Isteb4k
dismissed
yaroslavborbat’s stale review
The base branch was changed.
Isteb4k
force-pushed
the
feat/cdi/sds-clone-stragegy
branch
3 times, most recently
from
81cb1db to
4f66770
Compare
diafour
approved these changes
Dec 17, 2024
Isteb4k
force-pushed
the
feat/cdi/sds-clone-stragegy
branch
from
4f66770 to
feba3d0
Compare
yaroslavborbat
approved these changes
Dec 18, 2024
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
feat/cdi/sds-clone-stragegy
branch
from
feba3d0 to
42b492a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When cloning from PVC to PVC, it's necessary to select a cloning strategy. By default, the cloning strategy
snapshotis selected.However,
replicated.csi.storage.deckhouse.ioandlocal.csi.storage.deckhouse.iocan create snapshots only when using LVM Thin.To avoid errors, for LVM Thick, it's necessary to use
copycloning strategy (csi-cloneis also unavailable since the CSI itself creates a snapshot when usingcsi-clone).Checklist