refactor(api): split common package #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilrwx
force-pushed
the
refactor/api/split-common-package
branch
6 times, most recently
from
74d356f to
d05887e
Compare
danilrwx
force-pushed
the
refactor/api/split-common-package
branch
from
d05887e to
c6c0374
Compare
danilrwx
force-pushed
the
refactor/api/split-common-package
branch
2 times, most recently
from
baf60b8 to
7a997e1
Compare
Signed-off-by: Daniil Antoshin <[email protected]> fix: lint Signed-off-by: Daniil Antoshin <[email protected]> fix: remove package Signed-off-by: Daniil Antoshin <[email protected]>
danilrwx
force-pushed
the
refactor/api/split-common-package
branch
from
7a997e1 to
a86270f
Compare
LopatinDmitr
reviewed
Dec 6, 2024
images/virtualization-artifact/pkg/controller/importer/settings.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniil Antoshin <[email protected]>
LopatinDmitr
previously approved these changes
Dec 6, 2024
yaroslavborbat
requested changes
Dec 6, 2024
images/virtualization-artifact/pkg/common/annotations/annotations.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniil Antoshin <[email protected]>
yaroslavborbat
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring the overall package. Removing unused labels, annotations and envs. Separating utilities into different packages
Why do we need it, and what problem does it solve?
Improve code readability, remove unused functions and merge domain utilities
What is the expected result?
Updating the api
Checklist