Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): move common consts #531

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

danilrwx
Copy link
Contributor

@danilrwx danilrwx commented Nov 20, 2024

Description

Prepare for common package refactor. Delete unused labels, annotations and envs.

Why do we need it, and what problem does it solve?

Delete unused code

What is the expected result?

Sample public api of common package

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@danilrwx danilrwx marked this pull request as draft November 20, 2024 14:15
@danilrwx danilrwx marked this pull request as ready for review November 21, 2024 10:32
@danilrwx danilrwx force-pushed the refactor/api/move-common-consts branch from 349c714 to 5a646c9 Compare November 21, 2024 10:33
@danilrwx danilrwx force-pushed the refactor/api/move-common-consts branch 2 times, most recently from 10bc5c5 to 21c5eed Compare November 25, 2024 07:32
Signed-off-by: Daniil Antoshin <[email protected]>

refactor(api): del unused

Signed-off-by: Daniil Antoshin <[email protected]>

refactor(api): del unused

Signed-off-by: Daniil Antoshin <[email protected]>

refactor(api): move consts

Signed-off-by: Daniil Antoshin <[email protected]>

refactor(api): move consts

Signed-off-by: Daniil Antoshin <[email protected]>
@danilrwx danilrwx force-pushed the refactor/api/move-common-consts branch from 21c5eed to 4f2ce00 Compare November 25, 2024 11:13
@danilrwx danilrwx merged commit 7f0f09d into main Nov 26, 2024
12 checks passed
@danilrwx danilrwx deleted the refactor/api/move-common-consts branch November 26, 2024 08:10
nevermarine pushed a commit that referenced this pull request Dec 3, 2024
refactor(api): move common consts

Signed-off-by: Daniil Antoshin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants