test(api): refactor e2e label and annotation test case #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eofff
reviewed
Nov 12, 2024
Is it "Label and Annotation test case is now a part of E2E tests workflow again."? And, shouldn't we unlock this test for |
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
diafour
reviewed
Nov 15, 2024
eofff
previously approved these changes
Nov 19, 2024
hardcoretime
force-pushed
the
test/api/resource-deletion-step-in-e2e-tests
branch
from
3968af5 to
e45b43c
Compare
Base automatically changed from
test/api/resource-deletion-step-in-e2e-tests
to
main
November 26, 2024 08:55
- adapt existing label and annotation test case to updated API - fix typo and improve test cases contexts Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
test/api/refactor-e2e-label-and-annotation
branch
from
1a1caee to
ce4c56a
Compare
Yes, we will unlock this test in this PR. |
eofff
approved these changes
Nov 28, 2024
nevermarine
pushed a commit
that referenced
this pull request
Dec 3, 2024
- adapt existing label and annotation test case to updated API - fix typo and improve test cases contexts Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
It adapts
Label and Annotationtest case to updated Virtualization API and this test case does not be skipped in E2E workflow.What is the expected result?
Label and Annotationwill be checked again in E2E workflow.Checklist