feat(api): move calculation of scratch filesystem overhead to cdi controller #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CDI always requests scratch space with a Filesystem volume mode, regardless of the volume mode of the related
DataVolume. An additional overhead space should be reserved for the Filesystem volume.
By default, this overhead is taken from the CDI Config and is not dynamically updated based on the target PVC size.
As a result, the target PVC size with the overhead from the CDI Config may be insufficient to successfully complete
PVC creation.
To address this, since there is no strict formula for ext4 filesystem overhead, empirical estimates of the filesystem
overhead were provided based on the target PVC size:
Previously, this overhead was added at the level of our controller, which led to an undesirable increase in the size of images and disks. As part of this PR, the addition of an overhead is now taking place at the cdi controller level.
Checklist