fix(vd,vmbda): write occurred data volume errors to condition #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
feat/vd/pvc-importer-errors
branch
from
13e322e to
b68a1ff
Compare
Isteb4k
changed the title
Isteb4k
force-pushed
the
fix/vd/pvc-size-message
branch
from
00da5fb to
54393ce
Compare
Isteb4k
force-pushed
the
feat/vd/pvc-importer-errors
branch
13 times, most recently
from
c598492 to
b1233fd
Compare
Isteb4k
force-pushed
the
fix/vd/pvc-size-message
branch
from
54393ce to
9d63ef3
Compare
Isteb4k
force-pushed
the
feat/vd/pvc-importer-errors
branch
from
b1233fd to
a3d7add
Compare
Isteb4k
requested review from
yaroslavborbat
and removed request for
LopatinDmitr
Isteb4k
changed the title
Isteb4k
changed the title
yaroslavborbat
previously approved these changes
Aug 15, 2024
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
feat/vd/pvc-importer-errors
branch
from
a3d7add to
846a65f
Compare
yaroslavborbat
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some StorageClasses cause errors in the data volume, the CDI importer pod, and the PVC.
The error might be found either in the conditions or the events. CDI does not have a unified approach for storing errors.
As part of this task, I have propagated the errors from the conditions of the CDI importer pod to the conditions of the virtual disk.
Added a check to ensure the disk unplug operation is feasible before proceeding.
Improved the identification of conflicting VMBDA instances: now, a VMBDA instance is considered to be in conflict if it attempts to attach a disk that is already in use by another VMBDA instance, irrespective of whether the virtual machines match.
Checklist