refactor(kube-api-rewriter): add AdmissionReview response patch rewriter #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
previously approved these changes
Jul 3, 2024
yaroslavborbat
previously approved these changes
Jul 4, 2024
- Rewrite metadata in patches for mutating responses. - Full restore for object and oldObject in AdmisstionReview request. - Move admission request test to admission_review_test.go. - Add webhookRules to createTestRewriter. - Allow rewrite for JSON responses for non application/json Content-Type. E.g. text/plain responses from webhooks. Signed-off-by: Ivan Mikheykin <[email protected]>
diafour
force-pushed
the
refactor/kube-api-rewriter/admission-response-rewrite-metadata-patch
branch
from
0ffbf2b to
83b43f3
Compare
Signed-off-by: Ivan Mikheykin <[email protected]>
Isteb4k
approved these changes
Jul 4, 2024
fl64
deleted the
refactor/kube-api-rewriter/admission-response-rewrite-metadata-patch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Mutating webhook sets original label "kubevirt.io/vmi-name=vmi-name" to the InternalVirtualizationVirtualMachineInstanceMigration. virt-controller lost this resource, since labelSelector in watch is rewritten.
What is the expected result?
Migration works for VMs.
Checklist