Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vd,vi,cvi): fix capacity and cdrom #161

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix(vd,vi,cvi): fix capacity and cdrom #161

merged 1 commit into from
Jun 27, 2024

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Jun 26, 2024 •
edited
Loading

Description

  • Fixed the display of CD-ROM when calling kubectl get vd (previously, a false value was shown as empty).
  • Now we wait for the PVC to reach the Bound phase to set the actual value for disk Capacity.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k marked this pull request as ready for review June 26, 2024 15:49
@Isteb4k Isteb4k requested a review from yaroslavborbat June 26, 2024 18:04
@LopatinDmitr LopatinDmitr self-requested a review June 26, 2024 18:26
@Isteb4k Isteb4k merged commit 73f929d into main Jun 27, 2024
29 checks passed
@Isteb4k Isteb4k deleted the fix/api/capacity-and-cdrom branch June 27, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LopatinDmitr LopatinDmitr LopatinDmitr approved these changes

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

Assignees

@Isteb4k Isteb4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isteb4k @yaroslavborbat @LopatinDmitr