fix(core, dvcr): configure dvcr creds before contatinerd config #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yaroslavborbat <[email protected]>
fl64
changed the title
fl64
changed the title
fl64
approved these changes
Jun 13, 2024
universal-itengineer
pushed a commit
that referenced
this pull request
Jun 13, 2024
Description Fix the order of configuration steps to ensure that DVCR credentials are configured before merging containerd configurations. Why do we need it, and what problem does it solve? We currently have a bashible step 032_configure_containerd.sh with a weight of 32. This step merges the containerd configurations, which requires correct DVCR (Docker V2 Container Registry) credentials. To solve the problem where DVCR credentials must be configured in advance, this PR introduces a lower weight configuration step that runs before the containerd configuration step. Signed-off-by: yaroslavborbat <[email protected]> (cherry picked from commit 6cc4d26)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the order of configuration steps to ensure that DVCR credentials are configured before merging containerd configurations.
Why do we need it, and what problem does it solve?
We currently have a bashible step
032_configure_containerd.shwith a weight of 32. This step merges the containerd configurations, which requires correct DVCR (Docker V2 Container Registry) credentials. To solve the problem where DVCR credentials must be configured in advance, this PR introduces a lower weight configuration step that runs before the containerd configuration step.Checklist