fix(core, kubevirt): add ability to configure burst for virt-api rate limiter #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
changed the title
Isteb4k
force-pushed
the
refactor/crd/api-add-name-suffix
branch
from
9457918 to
35f2479
Compare
Isteb4k
force-pushed
the
fix/kubevirt/vms-migration
branch
from
13a57b1 to
d74862b
Compare
Isteb4k
changed the title
Isteb4k
force-pushed
the
fix/kubevirt/vms-migration
branch
from
d74862b to
c84163b
Compare
fl64
approved these changes
May 20, 2024
fl64
requested changes
May 20, 2024
Isteb4k
force-pushed
the
fix/kubevirt/vms-migration
branch
2 times, most recently
from
c7b7534 to
d476bba
Compare
fl64
force-pushed
the
refactor/crd/api-add-name-suffix
branch
from
1249071 to
847eaff
Compare
Isteb4k
force-pushed
the
fix/kubevirt/vms-migration
branch
from
d476bba to
b971fe5
Compare
diafour
reviewed
May 21, 2024
diafour
approved these changes
May 21, 2024
Isteb4k
force-pushed
the
fix/kubevirt/vms-migration
branch
from
6ef464f to
f486c10
Compare
… limiter Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
force-pushed
the
fix/kubevirt/vms-migration
branch
from
f486c10 to
522ecd9
Compare
fl64
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When migrating a big number of virtual machines (>50), we encounter a bottleneck in virt-api in the form of a rate limiter that prevents migration completion.
A patch has been updated to virt-api, enabling the configuration of Burst for the rate limiter via an environment variable VIRT_API_RATE_LIMITER_BURST.
Checklist