fix

Signed-off-by: yaroslavborbat <[email protected]>
deckhouse · Jan 17, 2025 · c94b18d · c94b18d
1 parent 6391a85
commit c94b18d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/api/subresources/types.go b/api/subresources/types.go
@@ -57,6 +57,7 @@ type VirtualMachineAddVolume struct {
 	VolumeKind string
 	PVCName    string
 	Image      string
+	AsCdrom    bool
 }
 
 // +genclient

diff --git a/api/subresources/v1alpha2/types.go b/api/subresources/v1alpha2/types.go
@@ -59,6 +59,7 @@ type VirtualMachineAddVolume struct {
 	VolumeKind      string `json:"volumeKind"`
 	PVCName         string `json:"pvcName"`
 	Image           string `json:"image"`
+	AsCdrom         bool   `json:"asCdrom"`
 }
 
 // +genclient

diff --git a/images/virtualization-artifact/pkg/apiserver/registry/vm/rest/add_volume.go b/images/virtualization-artifact/pkg/apiserver/registry/vm/rest/add_volume.go
@@ -103,16 +103,23 @@ func (r AddVolumeREST) requestFromKubevirt(opts *subresources.VirtualMachineAddV
 }
 
 func (r AddVolumeREST) genMutateRequestHook(opts *subresources.VirtualMachineAddVolume) (mutateRequestHook, error) {
+	var dd virtv1.DiskDevice
+	if opts.AsCdrom {
+		dd.CDRom = &virtv1.CDRomTarget{
+			Bus: virtv1.DiskBusSATA,
+		}
+	} else {
+		dd.Disk = &virtv1.DiskTarget{
+			Bus: virtv1.DiskBusSCSI,
+		}
+	}
+
 	hotplugRequest := AddVolumeOptions{
 		Name: opts.Name,
 		Disk: &virtv1.Disk{
-			Name: opts.Name,
-			DiskDevice: virtv1.DiskDevice{
-				Disk: &virtv1.DiskTarget{
-					Bus: "scsi",
-				},
-			},
-			Serial: opts.Name,
+			Name:       opts.Name,
+			DiskDevice: dd,
+			Serial:     opts.Name,
 		},
 	}
 	switch opts.VolumeKind {