fix(kube-api-rewriter): respond with correct error

Signed-off-by: Daniil Antoshin <[email protected]>
deckhouse · Dec 26, 2024 · 8c902b1 · 8c902b1
1 parent 1a482e2
commit 8c902b1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/images/kube-api-rewriter/pkg/proxy/handler.go b/images/kube-api-rewriter/pkg/proxy/handler.go
@@ -33,6 +33,7 @@ import (
 	"time"
 
 	"github.com/tidwall/gjson"
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 
 	"github.com/deckhouse/kube-api-rewriter/pkg/labels"
 	logutil "github.com/deckhouse/kube-api-rewriter/pkg/log"
@@ -186,10 +187,8 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, req *http.Request) {
 	resp, err := h.TargetClient.Do(req)
 	if err != nil {
 		logger.Error("Error passing request to the target", logutil.SlogErr(err))
-		http.Error(w, "Error passing request to the target", http.StatusInternalServerError)
+		http.Error(w, k8serrors.NewInternalError(err).Error(), http.StatusInternalServerError)
 		metrics.TargetResponseError()
-		// TODO return apimachinery NewInternalError
-		// https://github.com/kubernetes/apimachinery/blob/master/pkg/api/errors/errors.go
 		return
 	}