-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Yaroslav Borbat <[email protected]>
- Loading branch information
1 parent
a005749
commit 6435099
Showing
6 changed files
with
259 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
images/virtualization-artifact/pkg/migration/migration.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| Copyright 2025 Flant JSC | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package migration | ||
|
|
||
| import ( | ||
| "context" | ||
| "sync" | ||
| "time" | ||
|
|
||
| "github.com/deckhouse/deckhouse/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| "github.com/deckhouse/virtualization-controller/pkg/logger" | ||
| ) | ||
|
|
||
| type constructor func(client client.Client, logger *log.Logger) (Migration, error) | ||
|
|
||
| var newMigrations = []constructor{ | ||
| newQEMUMaxLength36, | ||
| } | ||
|
|
||
| type Migration interface { | ||
| Name() string | ||
| IsBlocking() bool | ||
| Migrate(ctx context.Context) error | ||
| } | ||
|
|
||
| type Controller struct { | ||
| client client.Client | ||
| log *log.Logger | ||
|
|
||
| blockingMigrations []Migration | ||
| nonBlockingMigrations []Migration | ||
| } | ||
|
|
||
| func NewController(client client.Client, log *log.Logger) *Controller { | ||
| return &Controller{ | ||
| client: client, | ||
| log: log, | ||
| } | ||
| } | ||
|
|
||
| func (c *Controller) Setup() error { | ||
| for _, fn := range newMigrations { | ||
| m, err := fn(c.client, c.log) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if m.IsBlocking() { | ||
| c.blockingMigrations = append(c.blockingMigrations, m) | ||
| } else { | ||
| c.nonBlockingMigrations = append(c.nonBlockingMigrations, m) | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (c *Controller) Run(ctx context.Context) { | ||
| run := func(wg *sync.WaitGroup, migrations []Migration) { | ||
| for _, m := range migrations { | ||
| wg.Add(1) | ||
| lg := c.log.With("name", m.Name()) | ||
| lg.Info("Running migration") | ||
|
|
||
| go func() { | ||
| defer lg.Info("Finished migration") | ||
| defer wg.Done() | ||
|
|
||
| for { | ||
| select { | ||
| case <-ctx.Done(): | ||
| return | ||
| default: | ||
| if err := m.Migrate(ctx); err != nil { | ||
| lg.Error("Failed to run migration, retry after 5s...", logger.SlogErr(err)) | ||
| time.Sleep(5 * time.Second) | ||
| continue | ||
| } | ||
| break | ||
| } | ||
| } | ||
| }() | ||
| } | ||
| } | ||
| unused := &sync.WaitGroup{} | ||
| used := &sync.WaitGroup{} | ||
|
|
||
| run(unused, c.nonBlockingMigrations) | ||
| run(used, c.blockingMigrations) | ||
| // Wait for blocked migrations only | ||
| used.Wait() | ||
| } |
116 changes: 116 additions & 0 deletions
116
images/virtualization-artifact/pkg/migration/qemu-max-length-36.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| Copyright 2025 Flant JSC | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package migration | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/deckhouse/deckhouse/pkg/log" | ||
| virtv1 "kubevirt.io/api/core/v1" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| "github.com/deckhouse/virtualization-controller/pkg/controller/kvbuilder" | ||
| "github.com/deckhouse/virtualization-controller/pkg/logger" | ||
| ) | ||
|
|
||
| const ( | ||
| // https://github.com/qemu/qemu/commit/75997e182b695f2e3f0a2d649734952af5caf3ee | ||
| maxSerialLength = 36 | ||
| qemuMaxLength36ControllerName = "qemu-max-length-36" | ||
| ) | ||
|
|
||
| func newQEMUMaxLength36(client client.Client, logger *log.Logger) (Migration, error) { | ||
| return &qemuMaxLength36{ | ||
| client: client, | ||
| logger: logger, | ||
| }, nil | ||
| } | ||
|
|
||
| type qemuMaxLength36 struct { | ||
| client client.Client | ||
| logger *log.Logger | ||
| } | ||
|
|
||
| func (r *qemuMaxLength36) Name() string { | ||
| return qemuMaxLength36ControllerName | ||
| } | ||
|
|
||
| func (r *qemuMaxLength36) IsBlocking() bool { | ||
| return true | ||
| } | ||
|
|
||
| func (r *qemuMaxLength36) Migrate(ctx context.Context) error { | ||
| kvvmList := &virtv1.VirtualMachineList{} | ||
| err := r.client.List(ctx, kvvmList) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for i := range kvvmList.Items { | ||
| kvvm := &kvvmList.Items[i] | ||
| if !r.needMigrate(&kvvm.Spec.Template.Spec) { | ||
| continue | ||
| } | ||
| copied := kvvm.DeepCopy() | ||
| r.mutateSpec(&copied.Spec.Template.Spec) | ||
| r.logger.Debug("Patch kvvm with new kvvmi spec", logger.SlogTryJson("newSpce", copied.Spec.Template.Spec)) | ||
| if err = r.client.Patch(ctx, kvvm, client.MergeFrom(copied)); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| kvvmiList := &virtv1.VirtualMachineInstanceList{} | ||
| err = r.client.List(ctx, kvvmiList) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for i := range kvvmiList.Items { | ||
| kvvmi := &kvvmiList.Items[i] | ||
| if !r.needMigrate(&kvvmi.Spec) { | ||
| continue | ||
| } | ||
| copied := kvvmi.DeepCopy() | ||
| r.mutateSpec(&copied.Spec) | ||
| r.logger.Debug("Patch kvvmi with new spec", logger.SlogTryJson("newSpce", copied.Spec)) | ||
| if err = r.client.Patch(ctx, kvvmi, client.MergeFrom(copied)); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (r *qemuMaxLength36) needMigrate(spec *virtv1.VirtualMachineInstanceSpec) bool { | ||
| for _, d := range spec.Domain.Devices.Disks { | ||
| serial := []rune(d.Serial) | ||
| if len(serial) > maxSerialLength { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } | ||
|
|
||
| func (r *qemuMaxLength36) mutateSpec(spec *virtv1.VirtualMachineInstanceSpec) { | ||
| for i := range spec.Domain.Devices.Disks { | ||
| d := &spec.Domain.Devices.Disks[i] | ||
| serial := []rune(d.Serial) | ||
| if len(serial) > maxSerialLength { | ||
| d.Serial = kvbuilder.GenerateSerial(d.Name) | ||
| } | ||
| } | ||
| } |