fix

Signed-off-by: Valeriy Khorunzhin <[email protected]>
deckhouse · Dec 16, 2024 · 50e54fb · 50e54fb
1 parent c014fdc
commit 50e54fb
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/images/virtualization-artifact/pkg/controller/vm/internal/lifecycle.go b/images/virtualization-artifact/pkg/controller/vm/internal/lifecycle.go
@@ -203,7 +203,7 @@ func (h *LifeCycleHandler) syncPodStarted(vm *virtv2.VirtualMachine, kvvm *virtv
 		}
 
 		// Try to extract error from kvvm Synchronized condition.
-		if isPodStartedError(kvvm.Status.PrintableStatus) {
+		if isPodStartedError(kvvm) {
 			msg := fmt.Sprintf("Failed to start pod: %s", kvvm.Status.PrintableStatus)
 			if kvvmi != nil {
 				msg = fmt.Sprintf("%s, %s", msg, kvvmi.Status.Phase)

diff --git a/images/virtualization-artifact/pkg/controller/vm/internal/util.go b/images/virtualization-artifact/pkg/controller/vm/internal/util.go
@@ -156,7 +156,16 @@ var mapReasons = map[string]vmcondition.Reason{
 	virtv1.GuestNotRunningReason: vmcondition.ReasonGuestNotRunningReason,
 }
 
-func isPodStartedError(phase virtv1.VirtualMachinePrintableStatus) bool {
+func isPodStartedError(vm *virtv1.VirtualMachine) bool {
+	const failedCreatePodReason = "FailedCreate"
+	synchronized := service.GetKVVMCondition(string(virtv1.VirtualMachineInstanceSynchronized), vm.Status.Conditions)
+	if synchronized != nil &&
+		synchronized.Status == corev1.ConditionFalse &&
+		synchronized.Reason == failedCreatePodReason {
+		return true
+	}
+
+	phase := vm.Status.PrintableStatus
 	return slices.Contains([]virtv1.VirtualMachinePrintableStatus{
 		virtv1.VirtualMachineStatusErrImagePull,
 		virtv1.VirtualMachineStatusImagePullBackOff,