fix(vi): nil recorder (#612)

* fix(vi): nil recorder Signed-off-by: Daniil Antoshin <[email protected]>
deckhouse · Dec 26, 2024 · 0c9af05 · 0c9af05
1 parent a60cbf3
commit 0c9af05
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 12 deletions.
diff --git a/images/virtualization-artifact/pkg/controller/vd/internal/source/http.go b/images/virtualization-artifact/pkg/controller/vd/internal/source/http.go
@@ -171,12 +171,7 @@ func (ds HTTPDataSource) Sync(ctx context.Context, vd *virtv2.VirtualDisk) (reco
 
 		return reconcile.Result{Requeue: true}, nil
 	case !podutil.IsPodComplete(pod):
-		ds.recorder.Eventf(
-			vd,
-			corev1.EventTypeNormal,
-			v1alpha2.ReasonDataSourceSyncStarted,
-			"Provisioning to DVCR is in progress", "podPhase", pod.Status.Phase,
-		)
+		log.Info("Provisioning to DVCR is in progress", "podPhase", pod.Status.Phase)
 
 		err = ds.statService.CheckPod(pod)
 		if err != nil {

diff --git a/images/virtualization-artifact/pkg/controller/vd/internal/source/registry.go b/images/virtualization-artifact/pkg/controller/vd/internal/source/registry.go
@@ -172,12 +172,7 @@ func (ds RegistryDataSource) Sync(ctx context.Context, vd *virtv2.VirtualDisk) (
 
 		return reconcile.Result{Requeue: true}, nil
 	case !podutil.IsPodComplete(pod):
-		ds.recorder.Eventf(
-			vd,
-			corev1.EventTypeNormal,
-			v1alpha2.ReasonDataSourceSyncStarted,
-			"Provisioning to DVCR is in progress", "podPhase", pod.Status.Phase,
-		)
+		log.Info("Provisioning to DVCR is in progress", "podPhase", pod.Status.Phase)
 
 		err = ds.statService.CheckPod(pod)
 		if err != nil {

diff --git a/images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref.go b/images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref.go
@@ -78,6 +78,7 @@ func NewObjectRefDataSource(
 		client:              client,
 		diskService:         diskService,
 		storageClassService: storageClassService,
+		recorder:            recorder,
 		viObjectRefOnPvc:    NewObjectRefDataVirtualImageOnPVC(recorder, statService, importerService, dvcrSettings, client, diskService, storageClassService),
 		vdSyncer:            NewObjectRefVirtualDisk(recorder, importerService, client, diskService, dvcrSettings, statService, storageClassService),
 	}

diff --git a/images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref_vd.go b/images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref_vd.go
@@ -70,6 +70,7 @@ func NewObjectRefVirtualDisk(
 	return &ObjectRefVirtualDisk{
 		importerService:     importerService,
 		client:              client,
+		recorder:            recorder,
 		diskService:         diskService,
 		statService:         statService,
 		dvcrSettings:        dvcrSettings,

diff --git a/images/virtualization-artifact/pkg/controller/vi/internal/source/registry.go b/images/virtualization-artifact/pkg/controller/vi/internal/source/registry.go
@@ -73,6 +73,7 @@ func NewRegistryDataSource(
 		client:              client,
 		diskService:         diskService,
 		storageClassService: storageClassService,
+		recorder:            recorder,
 	}
 }
 

diff --git a/images/virtualization-artifact/pkg/controller/vi/internal/source/upload.go b/images/virtualization-artifact/pkg/controller/vi/internal/source/upload.go
@@ -63,6 +63,7 @@ func NewUploadDataSource(
 	storageClassService *service.VirtualImageStorageClassService,
 ) *UploadDataSource {
 	return &UploadDataSource{
+		recorder:            recorder,
 		statService:         statService,
 		uploaderService:     uploaderService,
 		dvcrSettings:        dvcrSettings,