-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] Add LVMVolumeGroupSet #99
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorKram
force-pushed
the
v-kramarenko-adds-lvg-set
branch
15 times, most recently
from
October 2, 2024 14:55
7d8dedb
to
3611d4f
Compare
ViktorKram
force-pushed
the
v-kramarenko-adds-lvg-set
branch
from
October 2, 2024 17:27
7c1f376
to
3ceb1b7
Compare
astef
approved these changes
Oct 3, 2024
AleksZimin
approved these changes
Oct 11, 2024
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
force-pushed
the
v-kramarenko-adds-lvg-set
branch
from
November 4, 2024 09:05
3ceb1b7
to
79eff7c
Compare
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LVMVolumeGroupSet
- is a specialCR
, that allows to create severalLVMVolumeGroup
resources at once by a common template.To achieve that, users should create or update
LVMVolumeGroupSet
specified the desiredLVMVolumeGroup
resources creationstrategy
, nodes andblockDeviceSelector
. The controller will automatically createLVMVolumeGroups
and fill them with desired configuration.Note, that for now there is only one
LVMVolumeGroup
creation strategy -PerNode
. That means only oneLVMVolumeGroup
resource will be created on a single node, so in this case, the total amount of theLVMVolumeGroup
resources will be the same as specified nodes bynodeSelector
inLVMVolumeGroupSet
.Why do we need it, and what problem does it solve?
No more copy-pasta
LVMVolumeGroup
resources configuration.Much more user-friendly and faster way to create
LVMVolumeGroups
.What is the expected result?
LVMVolumeGroup
resources are created by theLVMVolumeGroupSet
and got in aReady
state.Checklist