Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Add LVMVolumeGroupSet #99

Merged
merged 17 commits into from
Nov 4, 2024
Merged

Conversation

ViktorKram
Copy link
Contributor

@ViktorKram ViktorKram commented Sep 30, 2024

Description

LVMVolumeGroupSet - is a special CR, that allows to create several LVMVolumeGroup resources at once by a common template.
To achieve that, users should create or update LVMVolumeGroupSet specified the desired LVMVolumeGroup resources creation strategy, nodes and blockDeviceSelector. The controller will automatically create LVMVolumeGroups and fill them with desired configuration.

Note, that for now there is only one LVMVolumeGroup creation strategy - PerNode. That means only one LVMVolumeGroup resource will be created on a single node, so in this case, the total amount of the LVMVolumeGroup resources will be the same as specified nodes by nodeSelector in LVMVolumeGroupSet.

Why do we need it, and what problem does it solve?

No more copy-pasta LVMVolumeGroup resources configuration.
Much more user-friendly and faster way to create LVMVolumeGroups.

What is the expected result?

LVMVolumeGroup resources are created by the LVMVolumeGroupSet and got in a Ready state.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@ViktorKram ViktorKram added the enhancement New feature or request label Sep 30, 2024
@ViktorKram ViktorKram self-assigned this Sep 30, 2024
@ViktorKram ViktorKram marked this pull request as draft September 30, 2024 19:55
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvg-set branch 15 times, most recently from 7d8dedb to 3611d4f Compare October 2, 2024 14:55
@ViktorKram ViktorKram requested a review from AleksZimin October 2, 2024 14:55
@ViktorKram ViktorKram marked this pull request as ready for review October 2, 2024 14:56
@ViktorKram ViktorKram requested a review from astef October 2, 2024 15:05
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-lvg-set branch from 7c1f376 to 3ceb1b7 Compare October 2, 2024 17:27
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin force-pushed the v-kramarenko-adds-lvg-set branch from 3ceb1b7 to 79eff7c Compare November 4, 2024 09:05
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin merged commit c02b44d into main Nov 4, 2024
9 checks passed
@AleksZimin AleksZimin deleted the v-kramarenko-adds-lvg-set branch November 4, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants