Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Add a BlockDevice labels watcher controller #94

Merged
merged 28 commits into from
Sep 27, 2024

Conversation

ViktorKram
Copy link
Contributor

@ViktorKram ViktorKram commented Sep 18, 2024

Description

Add a BlockDeviceLabelsWatcher controller to watch for the BlockDevice resources labels, and if some of the resources start to match or no longer match the LVMVolumeGroup spec.blockDeviceSelector, trigger such LVMVolumeGroup resource to update their configurations.

Why do we need it, and what problem does it solve?

Without the BlockDeviceLabelsWatcher-controller user's LVMVolumeGroup resources will not be able to be updated just in time and might have unexpected or incorrect states.

What is the expected result?

If a BlockDevice resource starts to match existing LVMVolumeGroup spec.blockDeviceSelector, such BlockDevice should be added to the LVMVolumeGroup (for example, corresponding VolumeGroup will be extended with a new block device)
If a BlockDevice no longer matches existing LVMVolumeGroup spec.blockDeviceSelector, such LVMVolumeGroup resource should got ConfigurationApplied false, as the LVMVolumeGroup resource lost its BlockDevice resource.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@ViktorKram ViktorKram added the enhancement New feature or request label Sep 18, 2024
@ViktorKram ViktorKram self-assigned this Sep 18, 2024
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch 7 times, most recently from 331d31b to e65dd09 Compare September 19, 2024 08:20
@ViktorKram ViktorKram changed the base branch from main to v-kramarenko-adds-bd-selector September 19, 2024 08:31
@ViktorKram ViktorKram changed the base branch from v-kramarenko-adds-bd-selector to main September 19, 2024 08:31
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch from e65dd09 to f544f6c Compare September 19, 2024 09:22
@ViktorKram ViktorKram marked this pull request as draft September 20, 2024 07:50
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch 6 times, most recently from 2c93bdd to 27ca536 Compare September 25, 2024 14:12
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch from 27ca536 to 52f98fa Compare September 26, 2024 08:15
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch from 52f98fa to 2031ace Compare September 26, 2024 12:04
@ViktorKram ViktorKram marked this pull request as ready for review September 26, 2024 12:04
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch from bd6aa15 to 4c66df0 Compare September 26, 2024 12:33
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-labels-watcher branch from dc43d5c to c18e230 Compare September 26, 2024 15:35
Signed-off-by: Viktor Kramarenko <[email protected]>
@AleksZimin AleksZimin merged commit b7bd55f into main Sep 27, 2024
6 of 9 checks passed
@AleksZimin AleksZimin deleted the v-kramarenko-adds-bd-labels-watcher branch September 27, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants