-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] Add a BlockDevice labels watcher controller #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
7 times, most recently
from
September 19, 2024 08:20
331d31b
to
e65dd09
Compare
ViktorKram
changed the base branch from
main
to
v-kramarenko-adds-bd-selector
September 19, 2024 08:31
ViktorKram
changed the base branch from
v-kramarenko-adds-bd-selector
to
main
September 19, 2024 08:31
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
from
September 19, 2024 09:22
e65dd09
to
f544f6c
Compare
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
6 times, most recently
from
September 25, 2024 14:12
2c93bdd
to
27ca536
Compare
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
from
September 26, 2024 08:15
27ca536
to
52f98fa
Compare
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
from
September 26, 2024 12:04
52f98fa
to
2031ace
Compare
astef
reviewed
Sep 26, 2024
images/sds-health-watcher-controller/src/pkg/controller/block_device_labels_watcher.go
Outdated
Show resolved
Hide resolved
AleksZimin
approved these changes
Sep 26, 2024
astef
reviewed
Sep 26, 2024
images/sds-health-watcher-controller/src/pkg/controller/block_device_labels_watcher.go
Show resolved
Hide resolved
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
from
September 26, 2024 12:33
bd6aa15
to
4c66df0
Compare
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-labels-watcher
branch
from
September 26, 2024 15:35
dc43d5c
to
c18e230
Compare
astef
reviewed
Sep 26, 2024
images/sds-health-watcher-controller/src/pkg/controller/block_device_labels_watcher.go
Outdated
Show resolved
Hide resolved
astef
reviewed
Sep 26, 2024
images/sds-health-watcher-controller/src/pkg/controller/block_device_labels_watcher.go
Outdated
Show resolved
Hide resolved
astef
approved these changes
Sep 26, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a BlockDeviceLabelsWatcher controller to watch for the
BlockDevice
resources labels, and if some of the resources start to match or no longer match theLVMVolumeGroup
spec.blockDeviceSelector
, trigger suchLVMVolumeGroup
resource to update their configurations.Why do we need it, and what problem does it solve?
Without the BlockDeviceLabelsWatcher-controller user's LVMVolumeGroup resources will not be able to be updated just in time and might have unexpected or incorrect states.
What is the expected result?
If a BlockDevice resource starts to match existing LVMVolumeGroup
spec.blockDeviceSelector
, suchBlockDevice
should be added to the LVMVolumeGroup (for example, corresponding VolumeGroup will be extended with a new block device)If a BlockDevice no longer matches existing LVMVolumeGroup
spec.blockDeviceSelector
, such LVMVolumeGroup resource should gotConfigurationApplied
false, as the LVMVolumeGroup resource lost its BlockDevice resource.Checklist