-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] Add BlockDevice resource selector for LVMVolumeGroups #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-selector
branch
27 times, most recently
from
September 5, 2024 15:36
83042be
to
d6f7eb1
Compare
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: v.oleynikov <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-adds-bd-selector
branch
from
September 17, 2024 14:18
0cf5122
to
70c85bf
Compare
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
astef
approved these changes
Sep 18, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
AleksZimin
approved these changes
Sep 18, 2024
duckhawk
approved these changes
Sep 18, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LvmVolumeGroup
kind is renamed toLVMVolumeGroup
kind.spec.blockDeviceSelector
field toLVMVolumeGroup
resources.spec.blockDeviceNames
field fromLVMVolumeGroup
resources (now you specify theBlockDevice
resources through the selector).spec.local
field.Why do we need it, and what problem does it solve?
The
LvmVolumeGroup
kind is renamed toLVMVolumeGroup
kind.This is needed for better code style and code consistency. To achieve this, the controller will provide a migration to replace the old
LvmVolumeGroup
CRD with the newLVMVolumeGroup
one. EveryLvmVolumeGroup
resource will be migrated as well, changing its kind toLVMVolumeGroup
with new spec functionality.BlockDeviceSelector
field inLVMVolumeGroup
resource's spec.This feature allows users to specify a selector for
BlockDevice
resources, which will be used to configure theLVMVolumeGroup
. The selector field replaces the oldspec.blockDeviceNames
field, providing an opportunity to fully configure theLVMVolumeGroup
resources while bootstrapping a cluster. It is also a more flexible way to operate withBlockDevice
resources for theLVMVolumeGroup
ones.Added
spec.local
field.This field includes only one subfield
nodeName
, which stores the information about the node the resource is placed on.What is the expected result?
spec.blockDeviceNames
are stored asspec.blockDeviceSelector
.Checklist