Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Add BlockDevice resource selector for LVMVolumeGroups #90

Merged
merged 78 commits into from
Sep 25, 2024

Conversation

ViktorKram
Copy link
Contributor

@ViktorKram ViktorKram commented Aug 29, 2024

Description

  1. The LvmVolumeGroup kind is renamed to LVMVolumeGroup kind.
  2. Added the spec.blockDeviceSelector field to LVMVolumeGroup resources.
  3. Removed the spec.blockDeviceNames field from LVMVolumeGroup resources (now you specify the BlockDevice resources through the selector).
  4. Added the spec.local field.

Why do we need it, and what problem does it solve?

  1. The LvmVolumeGroup kind is renamed to LVMVolumeGroup kind.
    This is needed for better code style and code consistency. To achieve this, the controller will provide a migration to replace the old LvmVolumeGroup CRD with the new LVMVolumeGroup one. Every LvmVolumeGroup resource will be migrated as well, changing its kind to LVMVolumeGroup with new spec functionality.

  2. BlockDeviceSelector field in LVMVolumeGroup resource's spec.
    This feature allows users to specify a selector for BlockDevice resources, which will be used to configure the LVMVolumeGroup. The selector field replaces the old spec.blockDeviceNames field, providing an opportunity to fully configure the LVMVolumeGroup resources while bootstrapping a cluster. It is also a more flexible way to operate with BlockDevice resources for the LVMVolumeGroup ones.

  3. Added spec.local field.
    This field includes only one subfield nodeName, which stores the information about the node the resource is placed on.

What is the expected result?

  1. lvmvolumegroups CRD and CRs have LVMVolumeGroup kind
  2. Old-kind LvmVolumeGroup resources are migrated to new-kind LVMVolumeGroup ones (they have Ready state, the information in them is correct, and their spec.blockDeviceNames are stored as spec.blockDeviceSelector.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@ViktorKram ViktorKram added the enhancement New feature or request label Aug 29, 2024
@ViktorKram ViktorKram self-assigned this Aug 29, 2024
@ViktorKram ViktorKram marked this pull request as draft August 29, 2024 19:42
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-selector branch 27 times, most recently from 83042be to d6f7eb1 Compare September 5, 2024 15:36
ViktorKram and others added 20 commits September 17, 2024 17:18
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>

Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-bd-selector branch from 0cf5122 to 70c85bf Compare September 17, 2024 14:18
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
@AleksZimin AleksZimin merged commit 249de28 into main Sep 25, 2024
6 of 8 checks passed
@AleksZimin AleksZimin deleted the v-kramarenko-adds-bd-selector branch September 25, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants