[controller] Fix a bug with labels containing spaces. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kramarenko <[email protected]>
duckhawk
approved these changes
Aug 29, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarebko-hot-fix-labels
branch
from
5cfda70 to
734ed79
Compare
AleksZimin
approved these changes
Aug 29, 2024
ViktorKram
added a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Viktor Kramarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As some of BlockDevice status values might have spaces within themselves, and the CR labels do not support spaces, we have to replace them with "-" sign with slug pkg.
Why do we need it, and what problem does it solve?
Because of the bug some of BlockDevice resources are not able to be created.
What is the expected result?
Any BlockDevice resource might be created.
Checklist