Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Fix internal hook and reduce image size #87

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

duckhawk
Copy link
Member

@duckhawk duckhawk commented Aug 21, 2024

Description

Fix internal hook because of Deckhouse internal changes, and removed external Deckhouse golang lib dependency

What is the expected result?

Smaller image size and correct module work

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@duckhawk duckhawk added the bug Something isn't working label Aug 21, 2024
@duckhawk duckhawk self-assigned this Aug 21, 2024
@duckhawk duckhawk requested a review from AleksZimin August 21, 2024 06:03
@duckhawk duckhawk force-pushed the fix-cert-generator-hook branch from 94cc211 to cb5b52d Compare August 22, 2024 11:14
@duckhawk duckhawk changed the title Fix [controller] Fix internal hook and reduce image size Aug 22, 2024
@duckhawk duckhawk marked this pull request as ready for review August 22, 2024 11:20
@AleksZimin AleksZimin merged commit 2796a04 into main Aug 22, 2024
7 checks passed
@AleksZimin AleksZimin deleted the fix-cert-generator-hook branch August 22, 2024 12:35
ViktorKram pushed a commit that referenced this pull request Sep 17, 2024
Signed-off-by: v.oleynikov <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants