[controller] Fix bug with unexpected LLV Failed statuses and phantom resourses #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-fixes-bug
branch
6 times, most recently
from
1f2432c to
b934a7d
Compare
ViktorKram
changed the title
ViktorKram
force-pushed
the
v-kramarenko-fixes-bug
branch
from
b934a7d to
a9a15bf
Compare
ViktorKram
force-pushed
the
v-kramarenko-fixes-bug
branch
2 times, most recently
from
e97f89c to
7ae6236
Compare
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-fixes-bug
branch
2 times, most recently
from
88356f6 to
62a55b0
Compare
Signed-off-by: Viktor Kramarenko <[email protected]>
ViktorKram
force-pushed
the
v-kramarenko-fixes-bug
branch
from
62a55b0 to
82bd50e
Compare
AleksZimin
approved these changes
Aug 29, 2024
ViktorKram
added a commit
that referenced
this pull request
Sep 17, 2024
…resourses (#84) Signed-off-by: Viktor Kramarenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug with unexpected LLV resources status Failed updates due to the cache was late to update itself.
Also, this cause to phantom LLV resources with status Created, though an actual LV on a node was removed.
Why do we need it, and what problem does it solve?
Less bad triggers due to scheduling pods, more consistent and valid data.
What is the expected result?
LLV resources do not get Failed status update. Neither phantom ones occur.
Checklist