[controller] Add parallel reconciliation to lvm_logical_volume_watcher. Add VG size validation to lvm_volume_group_watcher #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Viktor Kramarenko <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
commented
Apr 15, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
commented
Apr 15, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
dxavx
approved these changes
Apr 15, 2024
AleksZimin
changed the title
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
…lume finalizers before the resource deletion. Signed-off-by: Viktor Kramarenko <[email protected]> Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
AleksZimin
changed the title
dxavx
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces two improvements to our controllers:
lvm_logical_volume_watcher: Parallel Event Processing: We've refactored the reconciliation logic to handle incoming events in parallel, settingMaxConcurrentReconcilesto 10. This change aims to enhance the responsiveness and efficiency of the controller by processing multiple events simultaneously. Currently, this value is hardcoded and not configurable.lvm_volume_group_watcher: Volume Group Size Validation: Added a validation step for the size of all thin pools specified in theLVMVolumeGroupspec against the size of the volume group (VG) itself. If the combined sizes of the thin pools exceed the size of the VG, a validation error occurs, preventing any operations on theLVMVolumeGroup. This ensures that the VG's capacity is not overcommitted, maintaining system stability and data integrity.Why do we need it, and what problem does it solve?
The introduction of parallel reconciliation processing addresses potential bottlenecks in handling high volumes of events, particularly in large, dynamic environments. This enhancement allows
lvm_logical_volume_watcherto manage resources more effectively by reducing latency and improving overall performance.The size validation mechanism for thin pools versus the VG capacity is critical for preventing configuration errors that could lead to system failures or data loss. By ensuring that the thin pools do not exceed the available space in the VG, this feature adds an essential layer of protection against overprovisioning.
What is the expected result?
lvm_logical_volume_watchercontroller due to parallel processing of events.LVMVolumeGroupresources that could potentially exceed the physical capacities of the underlying storage.Checklist