Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Enhance LVMLogicalVolume handling: logging, size display, and event processing #28

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Mar 3, 2024

Description

This PR introduces several improvements to controller managing LVMLogicalVolume. Key enhancements include field organization, improved logging mechanisms, and an update in how actualSize is displayed to present a human-readable format. Additionally, the update function's event processing in the watcher has been refined to trigger only upon changes in the LVMLogicalVolume spec. The method for checking the actual size of LVs on nodes has also been optimized to query specific LVs rather than all LVs on the node, increasing efficiency and accuracy. Furthermore, LV search functionality now accounts for Volume Groups (VGs), ensuring more precise operations.

Why do we need it, and what problem does it solve?

These changes streamline controller operations and enhance user and system interaction by:

  • Improving the clarity and usefulness of logs.
  • Making size information more accessible and understandable for users.
  • Reducing unnecessary event processing, enhancing system performance.
  • Improving LV size checks and search functionality for better accuracy and efficiency.

What is the expected result?

  • Users and administrators will benefit from more informative and readable logs.
  • The actualSize field will now display in a user-friendly format, improving interface usability.
  • Event processing optimization will lead to reduced system load.
  • Enhanced LV size checking and search accuracy will ensure more reliable and efficient storage management.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin self-assigned this Mar 6, 2024
@AleksZimin AleksZimin added the enhancement New feature or request label Mar 6, 2024
Signed-off-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Aleksandr Zimin <[email protected]>
@AleksZimin AleksZimin changed the title [controller] Fix fields for LVMLogicalVolume [controller] Enhance LVMLogicalVolume handling: logging, size display, and event processing Mar 7, 2024
@AleksZimin AleksZimin requested review from ViktorKram and dxavx March 7, 2024 11:06
@AleksZimin AleksZimin marked this pull request as ready for review March 7, 2024 11:06
Signed-off-by: Viktor Kramarenko <[email protected]>
@AleksZimin AleksZimin merged commit 9c80fcc into main Mar 7, 2024
3 checks passed
@AleksZimin AleksZimin deleted the fix-fiels-for-lvmlogicalvolume branch March 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants